Conversation
This ensures that the legacy interface is only used for legacy tokens and that the modern interface can be used on the OptimismMintableERC20 token. Note that this is not the gas efficient way to implement this, but its ok for now as we are focused on minimal diff changes. In the future we could refactor this code to ensure that the ERC165Checker calls a minimal amount of times.
hive: Update op-geth image used for hive tests
Also fix compiler warning
fix(fd): use correct fn for getTotalElements
More accurately computes the gas limit for a migrated withdrawal. This is useful to prevent the gaslimit for large transactions from going over the consensus level block gas limit. It is unlikely for a transaction to go over the block gas limit, but this is a preventative fix just in case.
…-cheat op-wheel: update OVM owners cheat-code for migration testing
op-e2e: Run CI in parallel
…pair contracts-bedrock: fix standard bridge token pair checking
…ecks-l1xdm contracts-bedrock: remove deployment ownable check l1xdm
fix(atst): Fix module and main in package.json
op-node/service: Deduplicate logger + Better defaults
op-node: support shanghai L1 blockhash input verification
feat(op-batcher): Batcher Config Validation
…c-sync feat(op-node): Add alternative backup sync method via RPC
After some research, I discovered that we can iterate over Geth's storage in parallel as long as we don't share the state database. This PR updates the OVM ETH check script to parallelize state iteration across 64 workers. The parallelization works by partitioning storage keyspace based on the number of workers. To optimize further, I also moved the state balance checking into the main iteration loop to avoid unnecessary iteration. Note that state mutation must be done serially. Overall, this should safe about 40 minutes during the migration. This PR was tested by running it against a mainnet data directory. The entire process took approximately one hour. As part of this testing I discovered an invalid check in `check.go`, which was verifying the wrong storage slot in the withdrawals check function. This has been fixed.I confirmed with Mark that the updated `MessageSender` value is the correct one to be checking for. The filtering code was correct from the beginning.
op-chain-ops: Add parallel migration
🦋 Changeset detectedLatest commit: 60129ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Contributor
Author
|
Checked that the failures in main are all due to |
Contributor
Author
|
Not sure how to deal with the snyk failures though. Looks like dependabot has been bumping versions for us, but crypto is actually at 0.7.0 and dependabot was only able to bump it to 0.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this playbook