Skip to content

Trigger Releases #5172

Merged
zhwrd merged 469 commits intomasterfrom
develop
Mar 16, 2023
Merged

Trigger Releases #5172
zhwrd merged 469 commits intomasterfrom
develop

Conversation

@zchn
Copy link
Contributor

@zchn zchn commented Mar 16, 2023

Following this playbook

trianglesphere and others added 30 commits March 8, 2023 17:31
This ensures that the legacy interface is only used for
legacy tokens and that the modern interface can be used
on the OptimismMintableERC20 token.

Note that this is not the gas efficient way to implement this,
but its ok for now as we are focused on minimal diff changes.

In the future we could refactor this code to ensure that
the ERC165Checker calls a minimal amount of times.
hive: Update op-geth image used for hive tests
Also fix compiler warning
fix(fd): use correct fn for getTotalElements
More accurately computes the gas limit for a migrated
withdrawal. This is useful to prevent the gaslimit
for large transactions from going over the consensus
level block gas limit. It is unlikely for a transaction
to go over the block gas limit, but this is a preventative
fix just in case.
…-cheat

op-wheel: update OVM owners cheat-code for migration testing
…pair

contracts-bedrock: fix standard bridge token pair checking
…ecks-l1xdm

contracts-bedrock: remove deployment ownable check l1xdm
fix(atst): Fix module and main in package.json
op-node/service: Deduplicate logger + Better defaults
mergify bot and others added 7 commits March 15, 2023 20:33
op-node: support shanghai L1 blockhash input verification
feat(op-batcher): Batcher Config Validation
…c-sync

feat(op-node): Add alternative backup sync method via RPC
After some research, I discovered that we can iterate over Geth's storage in parallel as long as we don't share the state database. This PR updates the OVM ETH check script to parallelize state iteration across 64 workers. The parallelization works by partitioning storage keyspace based on the number of workers. To optimize further, I also moved the state balance checking into the main iteration loop to avoid unnecessary iteration. Note that state mutation must be done serially. Overall, this should safe about 40 minutes during the migration.

This PR was tested by running it against a mainnet data directory. The entire process took approximately one hour. As part of this testing I discovered an invalid check in `check.go`, which was verifying the wrong storage slot in the withdrawals check function. This has been fixed.I confirmed with Mark that the updated `MessageSender` value is the correct one to be checking for. The filtering code was correct from the beginning.
@zchn zchn requested review from a team, protolambda and trianglesphere as code owners March 16, 2023 15:35
@zchn zchn requested review from tynes and removed request for a team March 16, 2023 15:35
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: 60129ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/atst Minor
@eth-optimism/common-ts Patch
@eth-optimism/sdk Patch
@eth-optimism/fault-detector Patch
@eth-optimism/actor-tests Patch
@eth-optimism/chain-mon Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 60129ad
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6413372de8cfde0008be5143

@zchn zchn requested review from jvmi7 and nickbalestra and removed request for a team March 16, 2023 15:35
@mergify mergify bot added the A-indexer Area: indexer label Mar 16, 2023
@mergify mergify bot requested a review from roninjin10 March 16, 2023 15:35
@mergify mergify bot added sdk labels Mar 16, 2023
@zchn
Copy link
Contributor Author

zchn commented Mar 16, 2023

Checked that the failures in main are all due to Unauthorized.

@zchn
Copy link
Contributor Author

zchn commented Mar 16, 2023

Not sure how to deal with the snyk failures though. Looks like dependabot has been bumping versions for us, but crypto is actually at 0.7.0 and dependabot was only able to bump it to 0.1.0

@zhwrd zhwrd merged commit d5a63fa into master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.